beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vikkyrk <...@git.apache.org>
Subject [GitHub] beam pull request #2018: [BEAM-1467] dd cross-SDK implementations and tests ...
Date Thu, 16 Feb 2017 03:01:40 GMT
GitHub user vikkyrk opened a pull request:

    https://github.com/apache/beam/pull/2018

    [BEAM-1467] dd cross-SDK implementations and tests of WindowedValueCoder

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
    - Tests for GlobalWindowCoder
    - Cross-sdk implementation / tests for WindowedValueCoder
    - Note: PaneInfo isn't supported in python SDK yet, so we hard code the value to 0x0F
which represents PaneInfo.NO_FIRING
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam common_windowed_value_coder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2018.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2018
    
----
commit e0c5025ecc6529e2db04aff9e892ef045f7a7451
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2017-02-16T02:13:12Z

    Add cross-SDK implementations and tests of WindowedValueCoder

commit aa9840fe7c616c9ed85b475684fff61205449502
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2017-02-16T02:40:29Z

    Fix lint errors

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message