beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #2094: [BEAM-115] Concretize generic bits of the Runner AP...
Date Fri, 24 Feb 2017 02:10:18 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2094

    [BEAM-115] Concretize generic bits of the Runner API graph structure

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @dhalperi @robertwb 
    
    This gets rid of the excessive generic design of `GraphNode` and restores it to the original
design wherein each node is a `PTransform`. I have also merged the `bytes` of the SDK-specific
data and the `Any` that is SDK-independent data, since as has been pointed out we won't need
both.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam inline-runner-api

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2094
    
----
commit cc46d194cacbfb2244fde837f01b2ba0f2cedcdb
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-24T01:51:10Z

    Inline PTransform to GraphNode, removing generic design
    
    The GraphNode structure was made more generic to allow the Runner API
    and Fn API to share the graph data structure while carrying distinct
    payloads on nodes and edges. It seems that the Runner API was already
    sufficiently flexible for the Fn API to use its existing payload
    design.

commit 47289b5bc3a452e2866fb6515b55c7ef5d2835a8
Author: Kenneth Knowles <klk@google.com>
Date:   2017-02-24T02:06:56Z

    Condense FunctionSpec, merging data and params

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message