beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1148) Port PAssert away from Aggregators
Date Wed, 22 Mar 2017 22:01:41 GMT


ASF GitHub Bot commented on BEAM-1148:

GitHub user pabloem opened a pull request:

    [BEAM-1148] Port PAssert away from Aggregators

    This PR contains the following changes:
    * Changing `` code to use Metrics instead of Aggregators
    * Changing `` code to use Metrics. The change here also required adding
up different Metrics counters because Metrics are per-step; while Aggregators in Spark seem
to be adding accross steps.
    Additional bug fixes/code improvements:
    * Fixing a bug in `MetricFiltering`
    * Changing the Spark runner to use `MetricFiltering` instead of its own filtering implementation
- if that's okay.
    * I ran `mvn clean verify` successfully.
    Are there other places where I should be porting Aggregators checks to Metrics?

You can merge this pull request into a Git repository by running:

    $ git pull fix-passert

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2291
commit c6fe4986a720e5e9235be889f3a48844c0c85f0f
Author: Pablo <>
Date:   2017-03-22T21:25:31Z

    Tentative fixing PAssert for Spark runner tests.

commit 12342525888a6249122ab9327b71aa6cd75eba90
Author: Pablo <>
Date:   2017-03-22T22:00:23Z

    Fixing lint issue


> Port PAssert away from Aggregators
> ----------------------------------
>                 Key: BEAM-1148
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
> One step in the removal of Aggregators (in favor of Metrics) is to remove our reliance
on them for PAssert checking.

This message was sent by Atlassian JIRA

View raw message