beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1337) Use our coder infrastructure for coders for state
Date Wed, 01 Mar 2017 05:28:46 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889529#comment-15889529
] 

ASF GitHub Bot commented on BEAM-1337:
--------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/beam/pull/2133

    [BEAM-1337] Infer state coders

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/beam infer-state-coders

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2133
    
----
commit e5d4539809b594a6d5a233d916f0403f2f9b3e04
Author: Aviem Zur <aviemzur@gmail.com>
Date:   2017-03-01T05:27:57Z

    [BEAM-1337] Infer state coders

----


> Use our coder infrastructure for coders for state
> -------------------------------------------------
>
>                 Key: BEAM-1337
>                 URL: https://issues.apache.org/jira/browse/BEAM-1337
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Aviem Zur
>            Priority: Minor
>
> Today the user must explicitly provide any coders needed for serializing state data.
We'd rather use the coder registry and infer the coder.
> Currently all factory methods in {{StateSpecs}} take a coder argument. For example:
> {code}
> StateSpecs.value(coderForT);
> {code}
> We could leverage the coder registry and provide different overloads:
> TypeDescriptor:
> {code}
> StateSpecs.value(typeDescriptorForT); 
> {code}
> Reflection:
> {code}
> StateSpec.value();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message