beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1579) Runners should verify that PT overrides converged
Date Thu, 30 Mar 2017 22:48:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950008#comment-15950008
] 

ASF GitHub Bot commented on BEAM-1579:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2379

    [BEAM-1579] Use Batch Replacement API in the Dataflow Runner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam dataflow_batch_replacement

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2379
    
----
commit 29ffe5ee2a30df801730278971e3c74f180a34b2
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-23T16:38:53Z

    Use Batch Replacement API in the Dataflow Runner

----


> Runners should verify that PT overrides converged
> -------------------------------------------------
>
>                 Key: BEAM-1579
>                 URL: https://issues.apache.org/jira/browse/BEAM-1579
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core, runner-dataflow, runner-direct
>            Reporter: Eugene Kirpichov
>            Assignee: Thomas Groh
>
> PT overrides are applied in order, see https://issues.apache.org/jira/browse/BEAM-1578
.
> To make sure that the order is correct and avoid confusing errors, after applying the
overrides in order, we should verify that the pipeline has converged, i.e. the overrides no
longer match.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message