beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1655) Evaluate the PubsubUnboundedSource
Date Fri, 17 Mar 2017 22:32:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930840#comment-15930840
] 

ASF GitHub Bot commented on BEAM-1655:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2268

    [BEAM-1655] Maintain Safe-to-ACK IDs through Coder in PubsubIO

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    ACK them after NACKing all messages that have not been read.
    
    Remove checkStates around finalizeCheckpoint that are not consistent
    with the finalizeCheckpoint requirements.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam pubsub_io_checkpoints

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2268
    
----
commit d12b19a8fa9a917b5ffa72e38870347ec76cf71f
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-17T21:57:36Z

    Maintain Safe-to-ACK IDs through Coder in PubsubIO
    
    ACK them after NACKing all messages that have not been read.
    
    Remove checkStates around finalizeCheckpoint that are not consistent
    with the finalizeCheckpoint requirements.

----


> Evaluate the PubsubUnboundedSource
> ----------------------------------
>
>                 Key: BEAM-1655
>                 URL: https://issues.apache.org/jira/browse/BEAM-1655
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Ben Chambers
>            Assignee: Davor Bonaci
>
> This source includes a lot of assumptions & assertions that may cause problems on
runners that implement UnboundedSources differently. For example:
> 1. It requires that finalizeCheckpoint is called at most once.
> 2. It requires that the checkpoint be finalized within the pubsub timeout, or the messages
will be redelivered.
> ... (possibly other assumptions) ... 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message