beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1656) DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory
Date Mon, 13 Mar 2017 22:25:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923091#comment-15923091
] 

ASF GitHub Bot commented on BEAM-1656:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2237

    [BEAM-1656] Stop Double-finalizing checkpoints in the DirectRunner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Checkpoints don't need to be finalized before we restore from them.
    
    This cleans up some interactions with `PubSubIO`. I think that this shouldn't
    be a requirement, and I'm going to be sending out a tighter specification with
    how a Runner can interact with a CheckpointMark soon.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam never_double_finalize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2237
    
----
commit 8875bcf22e072d2e7e977c75ca1b82e413ce9ab6
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-13T22:22:24Z

    Stop Double-finalizing checkpoints in the DirectRunner
    
    Checkpoints don't need to be finalized before we restore from them.

----


> DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-1656
>                 URL: https://issues.apache.org/jira/browse/BEAM-1656
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Ben Chambers
>            Assignee: Thomas Groh
>
> In [getReader](https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java#L174)
we call finalize on the checkpoint that arrived in the incoming shard. Then later in [finishRead](https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java#L205)
we finalize the old checkpoint again.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message