beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <>
Subject [jira] [Commented] (BEAM-659) WindowFn#isCompatible should provide a meaningful reason
Date Wed, 10 May 2017 04:30:11 GMT


Kenneth Knowles commented on BEAM-659:

Since a risk-free PR for this is available, adding to 2.0.0. It can be punted if we cross
the finish line early. (how about those metaphors...)

> WindowFn#isCompatible should provide a meaningful reason
> --------------------------------------------------------
>                 Key: BEAM-659
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Huafeng Wang
>            Priority: Minor
>              Labels: easy, easyfix, starter
>             Fix For: 2.0.0
> {{WindowFn#isCompatible(...)}} returns a true/false answer without any explanation of
why; it suffers from a form of [boolean blindness|].
> We alleviated this for {{Coder#isDeterministic()}} by switching to {{Coder#verifyDeterministic()}}
which can raise an exception describing why it is not deterministic (it could just as easily
have been a return value).
> We should do the same for {{WindowFn#isCompatible(...)}}.
> See here:
> (a decent {{toString}} would go a long way, for immediate and trivial improvement)

This message was sent by Atlassian JIRA

View raw message