beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-1316) DoFn#startBundle should not be able to output
Date Tue, 02 May 2017 18:51:04 GMT


ASF GitHub Bot commented on BEAM-1316:

GitHub user sb2nov opened a pull request:

    [BEAM-1316] Remove the usage of mock from ptransform tests

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Mock patch creates problems if we try to pickle the DoFn so remove it and clean up the
    R: @aaltay PTAL

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-1316-improve-ptransform-test

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2836
commit 0eeb33bd1c41d1fe19ca71ce2b54485a9d7b717a
Author: Sourabh Bajaj <>
Date:   2017-05-02T18:48:19Z

    [BEAM-1316] Remove the usage of mock from ptransform tests


> DoFn#startBundle should not be able to output
> ---------------------------------------------
>                 Key: BEAM-1316
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>             Fix For: First stable release
> While within startBundle and finishBundle, the window in which elements are output is
not generally defined. Elements must always be output from within a windowed context, or the
{{WindowFn}} used by the {{PCollection}} may not operate appropriately.
> startBundle and finishBundle are suitable for operational duties, similarly to {{setup}}
and {{teardown}}, but within the scope of some collection of input elements. This includes
actions such as clearing field state within a DoFn and ensuring all live RPCs complete successfully
before committing inputs.
> Sometimes it might be reasonable to output from {{@FinishBundle}} but it is hard to imagine
a situation where output from {{@StartBundle}} is useful in a way that doesn't seriously abuse

This message was sent by Atlassian JIRA

View raw message