beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1984) Enable dependency analysis of non-compile dependencies
Date Tue, 02 May 2017 10:06:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992667#comment-15992667
] 

ASF GitHub Bot commented on BEAM-1984:
--------------------------------------

GitHub user iemejia opened a pull request:

    https://github.com/apache/beam/pull/2821

    [BEAM-1984] Fix scope for dependencies needed only for test/runtime purposes

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iemejia/beam BEAM-1984-enable-dep-analysis-for-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2821.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2821
    
----
commit 85b4b03675a3f23a4258f4156450e21ffc03621c
Author: Ismaël Mejía <iemejia@apache.org>
Date:   2017-05-02T09:58:54Z

    [BEAM-1984] Fix scope for dependencies needed only for test purposes

----


> Enable dependency analysis of non-compile dependencies
> ------------------------------------------------------
>
>                 Key: BEAM-1984
>                 URL: https://issues.apache.org/jira/browse/BEAM-1984
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>    Affects Versions: Not applicable
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Minor
>
> In the Beam parent pom at this moment we have a configuration on the maven dependency
plugin to ignore the verification of non-compile dependencies so unused or badly configured
dependencies that are used only for test or runtime purposes are not reported.
> {code:xml}
>               <!-- Ignore runtime-only dependencies in analysis -->
>               <ignoreNonCompile>true</ignoreNonCompile>
> {code}
> I discovered this case when I executed:
> {code}
> 	mvn clean install -Dmaven.test.skip=true
> {code}
> Notice that this is really particular because this does not compile the tests classes,
so it can detect when the ‘main’ classes are not using some code. This is different from
the behavior of:
> {code}
> 	mvn clean install -DskipTests=true
> {code}
> That does not complain because skipTests compiles the tests.
> For the first case (maven.test.skip) I got a warning ‘Unused declared dependencies
found’ so with this I discovered the test/runtime only dependencies that are not correctly
scoped. I will do a PR to fix this, because we can get rid of compile dependencies that are
test or runtime only.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message