beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1999) Change signature of set_runtime_options in value_provider.py
Date Mon, 22 May 2017 20:02:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020090#comment-16020090
] 

ASF GitHub Bot commented on BEAM-1999:
--------------------------------------

GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/3197

    [BEAM-1999] Remove resolved todo from value providers

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @mariapython @aaltay PTAL


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-1999-remove-old-comment

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3197
    
----
commit 82c337b4486444eee9b9b76b1a7001b6481808ca
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-05-22T20:00:52Z

    [BEAM-1999] Remove resolved todo from value providers

----


> Change signature of set_runtime_options in value_provider.py
> ------------------------------------------------------------
>
>                 Key: BEAM-1999
>                 URL: https://issues.apache.org/jira/browse/BEAM-1999
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Assignee: MarĂ­a GH
>             Fix For: Not applicable
>
>
> Change signature of this function to remove _unused_options_id, and add kwargs to make
it flexible for future changes



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message