beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Groh (JIRA)" <>
Subject [jira] [Reopened] (BEAM-2021) Fix Java's Coder class hierarchy
Date Mon, 01 May 2017 18:11:04 GMT


Thomas Groh reopened BEAM-2021:

There's a bit more work I'd like to get done, mainly splitting the class hierarchy out away
from "everything in the SDK is a structured coder". 

> Fix Java's Coder class hierarchy
> --------------------------------
>                 Key: BEAM-2021
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model-runner-api, sdk-java-core
>    Affects Versions: First stable release
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>             Fix For: First stable release
> This is thoroughly out of hand. In the runner API world, there are two paths:
> 1. URN plus component coders plus custom payload (in the form of component coders alongside
an SdkFunctionSpec)
> 2. Custom coder (a single URN) and payload is serialized Java. I think this never has
component coders.
> The other base classes have now been shown to be extraneous: they favor saving ~3 lines
of boilerplate for rarely written code at the cost of readability. Instead they should just
be dropped.
> The custom payload is an Any proto in the runner API. But tying the Coder interface to
proto would be unfortunate from a design perspective and cannot be done anyhow due to dependency

This message was sent by Atlassian JIRA

View raw message