beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2051) Reduce scope of the PCollectionView interface
Date Tue, 02 May 2017 20:32:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993682#comment-15993682
] 

ASF GitHub Bot commented on BEAM-2051:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2842

    [BEAM-2051] Mark all PCollectionView methods internal

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Add a note that the methods should not be considered to be accessible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam internal_view_methods

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2842.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2842
    
----
commit a7f7c55374015cdf33b71f9e944a940cfeceb712
Author: Thomas Groh <tgroh@google.com>
Date:   2017-05-02T17:31:21Z

    Mark all PCollectionView methods internal
    
    Add a note that the methods should not be considered to be accessible.

----


> Reduce scope of the PCollectionView interface
> ---------------------------------------------
>
>                 Key: BEAM-2051
>                 URL: https://issues.apache.org/jira/browse/BEAM-2051
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>             Fix For: First stable release
>
>
> Users should only ever use a PCollectionView class as a token to access a view. A Runner
can cast down to a more expressive type if required.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message