beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stas Levin (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (BEAM-2092) MicrobatchSource can be relieved of some of its methods since it's never used as an actual BoundedSource
Date Mon, 01 May 2017 11:12:04 GMT

     [ https://issues.apache.org/jira/browse/BEAM-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stas Levin resolved BEAM-2092.
------------------------------
       Resolution: Fixed
    Fix Version/s: First stable release

> MicrobatchSource can be relieved of some of its methods since it's never used as an actual
BoundedSource
> --------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2092
>                 URL: https://issues.apache.org/jira/browse/BEAM-2092
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>            Priority: Minor
>             Fix For: First stable release
>
>
> Currently {{MicrobatchSource}} extends {{BoundedSource}}, and thus must implement its
members (e.g., {{getEstimatedSizeBytes}}, {{createReader}}, etc.).
> Since {{MicrobatchSource}} is never actually used as a {{BoundedSource}}, it may derive
directly from {{Source}}, which will allow removing some of its methods that are not being
used.
> Similarly, {{MicrobatchSource.Reader}} does not perfectly fit the concepts of {{BoundedSource.BoundedReader}},
since it is actually a sort of hybrid between a bounded and an unbounded readers, and most
resembles the {{BoundedReadFromUnboundedSource.UnboundedToBoundedSourceAdapter}} class. This
makes it a nice candidate for deriving directly from  {{Source.Reader}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message