beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2212) ValueProvider-ification of core transforms makes logs and errors worse
Date Mon, 08 May 2017 17:07:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001099#comment-16001099
] 

ASF GitHub Bot commented on BEAM-2212:
--------------------------------------

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2956

    [BEAM-2212] Fix printing of file patterns in FileBasedSource

    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam b2212-fbs-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2956
    
----
commit 10546fb7315038533b3801567fad61e645b0564f
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-06T02:06:03Z

    [BEAM-2212] FileBasedSource: improve message when logging.
    
    ValueProvider should not be printed, rather the string instead.

commit 964e7661bd0fa1f5f94737e077e8b028649bb1a5
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-08T16:59:16Z

    [BEAM-2212] FileBasedSource: refactor to remove uses of fileOrPatternSpec.get()
    
    Makes it less likely to have errors from printing ValueProviders instead of runtime values

----


> ValueProvider-ification of core transforms makes logs and errors worse
> ----------------------------------------------------------------------
>
>                 Key: BEAM-2212
>                 URL: https://issues.apache.org/jira/browse/BEAM-2212
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Daniel Halperin
>
> E.g., we routinely log things like "Reading from StandardValueProvider{somefile}" instead
of "Reading from somefile".
> This should be audited and cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message