beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2314) Add ValidatesRunner test for custom merging windows
Date Mon, 29 May 2017 14:51:04 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028429#comment-16028429
] 

ASF GitHub Bot commented on BEAM-2314:
--------------------------------------

GitHub user echauchot opened a pull request:

    https://github.com/apache/beam/pull/3256

    [BEAM-2314] Add ValidatesRunner test for merging custom windows

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`.
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    R: @aljoscha 
    CC: @jbonofre 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/echauchot/beam BEAM-2314_merging_windows_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3256
    
----
commit 2b180ddcbdc7b21d85ed81cec381627012a4303d
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-05-29T10:05:51Z

    [BEAM-2314] Add ValidatesRunner test for merging custom windows

----


> Add ValidatesRunner test for custom merging windows
> ---------------------------------------------------
>
>                 Key: BEAM-2314
>                 URL: https://issues.apache.org/jira/browse/BEAM-2314
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Aljoscha Krettek
>            Assignee: Etienne Chauchot
>
> While working on BEAM-160 it was discovered that not all Runners supported custom merging
{{WindowFns}}. This is now fixed but we should still add a {{ValidatesRunner}} test for this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message