beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rober...@apache.org
Subject [2/4] beam git commit: Don't log full exception traceback in direct runner.
Date Tue, 09 May 2017 16:37:39 GMT
Don't log full exception traceback in direct runner.

It will be logged later if not caught.

This reduces duplication for failing tests, and noise for tests
expecting failure.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/f3f47f64
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/f3f47f64
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/f3f47f64

Branch: refs/heads/release-2.0.0
Commit: f3f47f64bd26f85d8de1c44e34f60c1cf372214b
Parents: 4069917
Author: Robert Bradshaw <robertwb@gmail.com>
Authored: Mon May 8 16:06:30 2017 -0700
Committer: Robert Bradshaw <robertwb@gmail.com>
Committed: Tue May 9 09:37:08 2017 -0700

----------------------------------------------------------------------
 sdks/python/apache_beam/runners/direct/executor.py | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/f3f47f64/sdks/python/apache_beam/runners/direct/executor.py
----------------------------------------------------------------------
diff --git a/sdks/python/apache_beam/runners/direct/executor.py b/sdks/python/apache_beam/runners/direct/executor.py
index 53aa3d0..0aa1aec 100644
--- a/sdks/python/apache_beam/runners/direct/executor.py
+++ b/sdks/python/apache_beam/runners/direct/executor.py
@@ -24,7 +24,6 @@ import logging
 import Queue
 import sys
 import threading
-import traceback
 from weakref import WeakValueDictionary
 
 from apache_beam.metrics.execution import MetricsContainer
@@ -308,7 +307,6 @@ class TransformExecutor(ExecutorService.CallableTask):
       self._completion_callback.handle_result(self._input_bundle, result)
       return result
     except Exception as e:  # pylint: disable=broad-except
-      logging.warning('Task failed: %s', traceback.format_exc(), exc_info=True)
       self._completion_callback.handle_exception(e)
     finally:
       self._evaluation_context.metrics().commit_physical(


Mime
View raw message