beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #2839: [BEAM-1340,BEAM-1345] Move WindowingStrategy from u...
Date Tue, 02 May 2017 19:22:24 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2839

    [BEAM-1340,BEAM-1345] Move WindowingStrategy from util to values

    WindowingStrategy is a property on PCollection that transform authors
    regularly mess with. It is part of the public API.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    I don't have a strong feeling that any of the public methods need to be marked `@Internal`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam WindowingStrategy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2839.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2839
    
----
commit 49ca126a0d372500a31ba22bd6d26d9110fad6ce
Author: Kenneth Knowles <klk@google.com>
Date:   2017-05-02T18:41:40Z

    Move WindowingStrategy from util to values
    
    WindowingStrategy is a property on PCollection that transform authors
    regularly mess with. It is part of the public API.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message