beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From meunierd <...@git.apache.org>
Subject [GitHub] beam pull request #2866: [BEAM-2150] Relax regex to support wildcard globbin...
Date Wed, 03 May 2017 20:24:33 GMT
GitHub user meunierd opened a pull request:

    https://github.com/apache/beam/pull/2866

    [BEAM-2150] Relax regex to support wildcard globbing for GCS

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`.
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    Something I've noticed is that Beam's usage of the GCS API doesn't leverage delimiters
so we're actually always iterating over the full set of objects after the prefix which is
why this PR is so tiny.
    
    Ideally, we can actually specify the delimiter `/` when not using  recursive wildcards
(`**`) for some efficiency gains.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/meunierd/beam BEAM-2150-gcs-recursive-wildcards

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2866
    
----
commit 6d0d6257040a9725b22f4c94bdaa2de388fd2e65
Author: Devon Meunier <devon.meunier@shopify.com>
Date:   2017-05-03T20:22:16Z

    [BEAM-2150] Relax regex to support wildcard globbing for GCS

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message