beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertwb <...@git.apache.org>
Subject [GitHub] beam pull request #2930: [BEAM-2166] Remove context from size estimating ope...
Date Fri, 05 May 2017 23:05:44 GMT
GitHub user robertwb opened a pull request:

    https://github.com/apache/beam/pull/2930

    [BEAM-2166] Remove context from size estimating operations.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam coders-context-sizes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2930
    
----
commit 1e36619bba7eb3e16078fb484961ebabc7331876
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-05-05T22:18:52Z

    Remove context from size estimate operations.

commit 7453171e4acb7e22505d172fcd790db599b33e54
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-05-05T22:23:03Z

    Remove uses of context in coder size estimation calls.
    
        find . -type f -name '*.java' | xargs sed -i '' 's/\([a-zA-Z]*[bB]yteSize[a-zA-Z]*[(].*\),
[^,]*[Cc]ontext[^,()]*\([(][)]\)*[)]/\1)/'
    
    plus a one-off Python script and some manual fixups.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message