beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <>
Subject [GitHub] beam pull request #2936: DO NOT MERGE - Direct runner debugging
Date Sat, 06 May 2017 02:51:58 GMT
GitHub user dhalperi opened a pull request:

    DO NOT MERGE - Direct runner debugging

    R: @tgroh 
    1. Converting all the executor services seems to have done the trick on the 60s delay.
We should always uses the ones that take `ThreadPoolBuilders`! (Or actually implement the
"one shared executor" task).
    2. Added a bunch of debugging logs, finding many seconds of slowly removing timers. Maybe
that's useful information?
    Logs in this gist:

You can merge this pull request into a Git repository by running:

    $ git pull direct-runner-debug

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2936
commit b76adf558d0db963fa41e2690a5f90db29a5fdaa
Author: Dan Halperin <>
Date:   2017-05-06T02:06:03Z

    FileBasedSource: improve message
    ValueProvider should not be printed, rather the string instead.

commit 0ee86d2f7f985647da9801d57490ad0885be8d75
Author: Dan Halperin <>
Date:   2017-05-06T02:49:29Z

    Some DirectRunner debugging


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message