beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <...@git.apache.org>
Subject [GitHub] beam pull request #2956: [BEAM-2212] Fix printing of file patterns in FileBa...
Date Mon, 08 May 2017 17:06:19 GMT
GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2956

    [BEAM-2212] Fix printing of file patterns in FileBasedSource

    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam b2212-fbs-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2956
    
----
commit 10546fb7315038533b3801567fad61e645b0564f
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-06T02:06:03Z

    [BEAM-2212] FileBasedSource: improve message when logging.
    
    ValueProvider should not be printed, rather the string instead.

commit 964e7661bd0fa1f5f94737e077e8b028649bb1a5
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-08T16:59:16Z

    [BEAM-2212] FileBasedSource: refactor to remove uses of fileOrPatternSpec.get()
    
    Makes it less likely to have errors from printing ValueProviders instead of runtime values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message