beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <...@git.apache.org>
Subject [GitHub] beam pull request #2958: [BEAM-2212] Cherry-pick #2956 into release-2.0.0 br...
Date Mon, 08 May 2017 18:52:05 GMT
GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2958

    [BEAM-2212] Cherry-pick #2956 into release-2.0.0 branch

    R: @davorbonaci 
    
    May not be worth CPing, it's just improving LOGs and error messages. Thoughts?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam cp-2956

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2958.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2958
    
----
commit 32539c70e1661c62730939f158d14fcf543e2237
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-06T02:06:03Z

    [BEAM-2212] FileBasedSource: improve message when logging.
    
    ValueProvider should not be printed, rather the string instead.

commit 1e2b6dbaacde05d4074172df0ed77a6ffbac83b6
Author: Dan Halperin <dhalperi@google.com>
Date:   2017-05-08T16:59:16Z

    [BEAM-2212] FileBasedSource: refactor to remove uses of fileOrPatternSpec.get()
    
    Makes it less likely to have errors from printing ValueProviders instead of runtime values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message