beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] beam pull request #2988: [BEAM-2147] Re-enable UsesTimersInParDo tests on Da...
Date Tue, 09 May 2017 04:50:48 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-2147] Re-enable UsesTimersInParDo tests on Dataflow, by fixing TestDataflowRunner
and PAssert

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull DataflowRunner-timers

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2988
commit 1a4910b1b73330094a1e1033ffde20e41b7024e3
Author: Kenneth Knowles <>
Date:   2017-05-09T03:07:29Z

    Allow any throwable in PAssert to constitute adequate failure
    Currently, some PAssert tests require an AssertionError to be thrown. This
    succeeds on all runners only because many gratuitously throw AssertionError
    when they don't actually know that an assertion has failed.
    The spec is just that a pipeline has to fail. We don't have a good enough story
    around exception propagation to have such a strict - and fake - spec. And it
    isn't cross-language anyhow FWIW, looking forward to the possibility of running
    a PAssert in a pipeline combining multiple SDK harnesses.

commit 01fd6cc568a7af05f260613197165bfc2f8ee86b
Author: Kenneth Knowles <>
Date:   2017-04-30T23:08:48Z

    TestDataflowRunner: throw AssertionError only when assertion known failed
    It is quite confusing to receive an assertion error when in fact the pipeline
    has crashed because of user error interacting with e.g. timers.

commit 898731b19a630ffc8ec8062acb0fd53bd4995635
Author: Kenneth Knowles <>
Date:   2017-02-14T22:54:11Z

    Re-enable UsesTimersInParDo tests in Dataflow runner


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message