beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wtanaka <...@git.apache.org>
Subject [GitHub] beam pull request #3139: Clean up exception signatures
Date Sun, 14 May 2017 20:39:32 GMT
GitHub user wtanaka opened a pull request:

    https://github.com/apache/beam/pull/3139

    Clean up exception signatures

    Strengthen some "throws Exception" declarations
    
    CoderException extends IOException so it's not necessary to declare
    both in "throws"
    
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wtanaka/beam BEAM-2293

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3139
    
----
commit 5dec09f884b5a085bd528f6881d8334930bc0a89
Author: wtanaka.com <wtanaka@yahoo.com>
Date:   2017-05-14T18:55:27Z

    [BEAM-2293] Rename Top.{Largest,Smallest=>Natural,Reversed}
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message