beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hepeknet <...@git.apache.org>
Subject [GitHub] beam pull request #3142: [BEAM-2276] make it easier to specify windowed file...
Date Mon, 15 May 2017 10:58:16 GMT
GitHub user hepeknet opened a pull request:

    https://github.com/apache/beam/pull/3142

    [BEAM-2276] make it easier to specify windowed filename policy

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-2276] make it easier to specify windowed filename policy`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    @dhalperi @jbonofre @reuvenlax 
    
    this is probably better than just throwing exception. This way full compatibility (no
need to specify windowing template). Also, users can always specify their own policy in case
they need more control.
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hepeknet/beam BEAM-2276

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3142
    
----
commit d1034ae48fe9c52546d8a67d20cc5472e2b98e28
Author: Borisa Zivkovic <borisa.zivkovic@huawei.com>
Date:   2017-05-15T07:56:19Z

    adding windowing into default filename policy

commit a5ce4966584ef2fc6cfa87b33c38b852ae223ab6
Author: Borisa Zivkovic <borisa.zivkovic@huawei.com>
Date:   2017-05-15T10:30:19Z

    adding windowed file naming policy to DefaultFileNamePolicy

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message