beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Sisk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2460) Make python maven variables available elsewhere
Date Tue, 20 Jun 2017 23:50:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056682#comment-16056682
] 

Stephen Sisk commented on BEAM-2460:
------------------------------------

You are correct, that does mean that a project that wants to use python has have a hardcoded
string (project.parent.parent...basedir) to know how to find the root pom.

I think the solution I propose here is the best solution I know of because:
1. It doesn't require modifying every pom file
2. It doesn't require adding 2 copies of the same groovy code to the root pom file
3. It should allow for easy copy pasting between io projects that "just works"
4. If a project is going to break because of this change, it'll be a project where the code
snippet has been added, giving people a fighting chance at debugging the error. 

If someone from the community has a suggestion on a better solution, I'm all ears, but based
on the above stackoverflow discussions, I believe this is the best one for the particular
problem that we have.

> Make python maven variables available elsewhere
> -----------------------------------------------
>
>                 Key: BEAM-2460
>                 URL: https://issues.apache.org/jira/browse/BEAM-2460
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core, sdk-py
>            Reporter: Stephen Sisk
>            Assignee: Stephen Sisk
>            Priority: Minor
>
> We're planning to start using perfkit to make it easy for users to run the IO ITs. Perfkit
is a python app, so we'll need to invoke the python interpreter. 
> findSupportedPython calculates this and sets the python.interpreter.bin variable. It
currently does so in the python project. 
> I believe the correct answer here is to move findSupportedPython so that's it's invoked
in the root pom. (but perhaps there's a more maven-y approach to this problem?) 
> cc [~altay] [~markflyhigh] [~jasonkuster] [~davor]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message