beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertwb <...@git.apache.org>
Subject [GitHub] beam pull request #3339: Actually test the fn_api_runner.
Date Fri, 09 Jun 2017 23:48:04 GMT
GitHub user robertwb opened a pull request:

    https://github.com/apache/beam/pull/3339

    Actually test the fn_api_runner.

    The test suite was not being run due to a typo.
    Fix breakage due to changes in the code in the meantime.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam fn-api-runner-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3339
    
----
commit 1db42923b81eab162eb6bf6a563505aff50cbbfa
Author: Robert Bradshaw <robertwb@google.com>
Date:   2017-06-09T23:44:55Z

    Actually test the fn_api_runner.
    
    The test suite was not being run due to a typo.
    Fix breakage due to changes in the code in the meantime.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message