beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From takidau <>
Subject [GitHub] beam pull request #3384: [BEAM-2459] Remove UnsupportedOperationVisitor, whi...
Date Fri, 16 Jun 2017 23:22:36 GMT
GitHub user takidau opened a pull request:

    [BEAM-2459] Remove UnsupportedOperationVisitor, which is currently just a no-op

    AFAICT, UnsupportedOperationVisitor just extends SqlShuttle with no overrides, which means
it does nothing when it visits SqlNodes. As such, the one use of it in BeamQueryPlanner is
a no-op. Removing, unless there is a good reason not to.

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-2459

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3384
commit 5276d2381cb638e01ada16b09dd52cdda286590e
Author: Tyler Akidau <>
Date:   2017-06-16T23:16:46Z

    Remove UnsupportOperationVisitor, which is currently just a no-op


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message