beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2684) AmqpIOTest is flaky
Date Thu, 10 Aug 2017 20:07:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122233#comment-16122233
] 

ASF GitHub Bot commented on BEAM-2684:
--------------------------------------

GitHub user alex-filatov opened a pull request:

    https://github.com/apache/beam/pull/3714

    [BEAM-2684] Fix flaky AmqpIOTest

    Source of the flakiness is a race between sender and receiver. In a peer-to-peer mode
receiver must be running before sender starts sending messages. When this's not the case sender
gets stuck in a 'send' method. AMQP broker solves the problem by eliminating sender/receiver
startup order requirement.
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alex-filatov/beam beam-2684-fix-flaky-amqpiotest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3714.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3714
    
----
commit d9456d6f4f2055d76e7e4f47263d5a8019137944
Author: Alex Filatov <alex-filatov@users.noreply.github.com>
Date:   2017-08-10T20:02:37Z

    [BEAM-2684] Fix flaky AmqpIOTest.
    
    Source of the flakiness is a race between sender and receiver. In a peer-to-peer mode
receiver must be running before sender starts sending messages. When this's not the case sender
gets stuck in a 'send' method. AMQP broker solves the problem by eliminating sender/receiver
startup order requirement.

----


> AmqpIOTest is flaky
> -------------------
>
>                 Key: BEAM-2684
>                 URL: https://issues.apache.org/jira/browse/BEAM-2684
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Eugene Kirpichov
>            Assignee: Jean-Baptiste Onofré
>
> This test is often timing out, and has been doing that for a while, causing unrelated
PRs to fail randomly. I've gotten into the habit of excluding sdks/java/io/amqp when running
"mvn verify" and I suppose it's not a good habit :) 
> Example failure: https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/13424/console



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message