beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2734) Dataflow ValidatesRunner broken at HEAD
Date Fri, 04 Aug 2017 23:52:00 GMT


ASF GitHub Bot commented on BEAM-2734:

GitHub user jkff opened a pull request:

    [BEAM-2734] Unbreaks some Dataflow ValidatesRunner tests

    This is a partial revert of, changing UnboundedReadFromBoundedSource
to be identical to the version before that PR.
    The Source is serialized in the pipeline and deserialized on the worker using the worker's
different (fixed per-worker) version of runners-core-construction so the serialVersionUID
has to match.
    This Source does not declare a serialVersionUID, so one is computed by the JVM automatically,
and in practice that means the class needs to be completely identical.
    The current PR is a quick emergency fix. The right solution is I suppose to declare a
serialVersionUID for everything serializable in runners-core-construction, or to make the
worker not contain a fixed version of runners-core-construction (not sure if it's feasible)
- but it's outside the scope of this PR.
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull unbreak-serialization

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3693
commit fc0c3c00613ab6524d621353ea44b5fb0646bcfa
Author: Eugene Kirpichov <>
Date:   2017-08-04T23:46:42Z

    [BEAM-2734] Unbreaks some Dataflow ValidatesRunner tests


> Dataflow ValidatesRunner broken at HEAD
> ---------------------------------------
>                 Key: BEAM-2734
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>            Priority: Critical
> Last stable build (#3567), 23 days ago
> We need to fix this.
> One of the issues is something I broke recently myself: SplittableDoFnTest is broken
due to serialization incompatibility by which slightly
changed that BoundedToUnboundedSourceAdapter class, which changed its serialVersionUID. I
don't know why this is so fragile - we should also fix the fact that it is so fragile.

This message was sent by Atlassian JIRA

View raw message