beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2735) testMergingCustomWindows tests are incorrect
Date Mon, 07 Aug 2017 22:08:00 GMT


ASF GitHub Bot commented on BEAM-2735:

GitHub user tgroh opened a pull request:

    [BEAM-2735] Update Custom Window Merging Tests

    Update the merge windows to be order-independent.
    Follow this checklist to help us incorporate your contribution quickly and easily:
     - [ ] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License

You can merge this pull request into a Git repository by running:

    $ git pull custom_merging_test

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3698


> testMergingCustomWindows tests are incorrect
> --------------------------------------------
>                 Key: BEAM-2735
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.2.0
>            Reporter: Thomas Groh
>            Assignee: Etienne Chauchot
> If the input is rewritten to use to use {{TestStream}}, and executes in the DirectRunner,
the tests fail. My expectation is that this is due to a disagreement in what the tests expect
to be merged (if all of the merging logic is run only once), as opposed to running the merging
logic incrementally with a perfect watermark.
> This is also causing failures in the Dataflow {{ValidatesRunner}} suite.
> {code:java}
>     PCollection<String> inputCollection =
>         pipeline.apply(
>             TestStream.create(StringUtf8Coder.of())
>                 .advanceWatermarkTo(
>                 .addElements("big")
>                 .advanceWatermarkTo(
>                 .addElements("small1")
>                 .advanceWatermarkTo(
>                 .addElements("small2")
>                 .advanceWatermarkTo(
>                 .advanceWatermarkToInfinity());
>  {code}

This message was sent by Atlassian JIRA

View raw message