beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2781) Should have a canonical Compression enum
Date Fri, 18 Aug 2017 23:34:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133779#comment-16133779
] 

ASF GitHub Bot commented on BEAM-2781:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/3737

    [BEAM-2781] Adds a canonical Compression enum for file-based IOs

    R: @lukecwik 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam compression-type

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3737.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3737
    
----
commit 12876d43a961dd8ff9dba5f4cffcfbe643927eee
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-08-18T23:17:20Z

    Adds a canonical Compression enum for file-based IOs

----


> Should have a canonical Compression enum
> ----------------------------------------
>
>                 Key: BEAM-2781
>                 URL: https://issues.apache.org/jira/browse/BEAM-2781
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>
> There are multiple equivalent enums in the Beam Java SDK representing a compresison type:
> TextIO.CompressionType
> TFRecordIO.CompressionType
> XmlIO.CompressionType
> FileBasedSink.CompressionType
> CompressedSource.CompressionMode
> This is ugly and we should unify them. That is also necessary to enable authors of new
file-based IOs to support compression without duplicating this functionality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message