beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2844) Support implicit side inputs
Date Wed, 06 Sep 2017 06:23:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154868#comment-16154868
] 

ASF GitHub Bot commented on BEAM-2844:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/3814

    [BEAM-2844] Introduces PCollectionView.get()

    https://issues.apache.org/jira/browse/BEAM-2844
    
    Supports it for DoFn in the various DoFnRunner's and DoFnTester. Support in CombineFn
remains.
    
    Introduces a category tag UsesImplicitSideInputs, currently excluded in Dataflow runner
- that will be fixed in a follow-up PR after service-side changes, and the category will be
removed.
    
    R: @lukecwik 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam side-input

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3814.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3814
    
----
commit 90ddc0d1171b3850d55e9ddbbee45abe48ba4086
Author: Eugene Kirpichov <ekirpichov@gmail.com>
Date:   2017-09-06T05:11:34Z

    Introduces PCollectionView.get()

----


> Support implicit side inputs
> ----------------------------
>
>                 Key: BEAM-2844
>                 URL: https://issues.apache.org/jira/browse/BEAM-2844
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core, sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>
> https://lists.apache.org/thread.html/cc543556cc709a44ed92262207215eaa0e43a0f573c630b6360d4edc@%3Cdev.beam.apache.org%3E
> Implement access to side inputs from arbitrary code via PCollectionView.get().
> Not necessarily in scope of this bug: implement inference of which side inputs are needed
by detecting fields with a @SideInput annotation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message