beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markflyhigh <...@git.apache.org>
Subject [GitHub] beam pull request #3879: [BEAM-2762] Python code coverage report in Postcomm...
Date Thu, 21 Sep 2017 06:22:14 GMT
GitHub user markflyhigh opened a pull request:

    https://github.com/apache/beam/pull/3879

    [BEAM-2762] Python code coverage report in Postcommit

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    Use coverage.py to run py27gcp test suite in order to generate coverage report in Python
postcommit build.
     - Add `cover` env in `tox.ini` which run `py27gcp` and generate report.
     - Report will be printed to test log and also in a xml file.
     - Only enable the coverage report in python postcommit since precommit build already
takes ~30mins with existing test suites. Run `py27gcp` in code coverage will add ~7mins to
the build. (thoughts?)
    
    Future:
    Send coverage report to coverage service (like `coveralls.io`). The known issue for `coveralls.io`
is that reports from different languages will mix together in `coveralls.io` and record as
history data.
    
    +R: @charlesccychen 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam coverage-report

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3879.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3879
    
----
commit 0c2a82c6d032a6d00c572910b0696c2a73cf70eb
Author: Mark Liu <markliu@google.com>
Date:   2017-09-21T06:08:09Z

    [BEAM-2762] Python code coverage report in Postcommit

----


---

Mime
View raw message