beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1872) implement Reshuffle transform in python, make it experimental in Java
Date Tue, 28 Nov 2017 23:23:02 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269686#comment-16269686
] 

ASF GitHub Bot commented on BEAM-1872:
--------------------------------------

udim commented on a change in pull request #4040: [BEAM-1872] Add IdentityWindowFn for use
in Reshuffle
URL: https://github.com/apache/beam/pull/4040#discussion_r153653667
 
 

 ##########
 File path: sdks/python/apache_beam/testing/util.py
 ##########
 @@ -80,9 +125,11 @@ def assert_that(actual, matcher, label='assert_that'):
 
   Args:
     actual: A PCollection.
-    matcher: A matcher function taking as argument the actual value of a
-      materialized PCollection. The matcher validates this actual value against
-      expectations and raises BeamAssertException if they are not met.
+    matcher: Two options:
+      1. A matcher function taking as argument the actual value of a
+      materialized PCollection. The matcher validates this actual value
+      against expectations and raises BeamAssertException if they are not met.
+      2. An instance of WindowedValueMatcher.
 
 Review comment:
   <!--thread_id:cc_151221512_t; commit:4fa4caa4b4991fe994ce3938f37be975421c6761; resolved:1-->
   <!--section:context-quote-->
   > **udim** wrote:
   > I thought of doing that, but how does assert_that know if matcher accepts values or
TestWindowedValues?
   
   <!--section:body-->
   Acknowledged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> implement Reshuffle transform in python, make it experimental in Java
> ---------------------------------------------------------------------
>
>                 Key: BEAM-1872
>                 URL: https://issues.apache.org/jira/browse/BEAM-1872
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core, sdk-py-core
>            Reporter: Ahmet Altay
>            Assignee: Udi Meiri
>              Labels: sdk-consistency
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message