beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3041) Add portable Python SDK container setup support
Date Wed, 29 Nov 2017 03:16:01 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270045#comment-16270045
] 

ASF GitHub Bot commented on BEAM-3041:
--------------------------------------

herohde commented on a change in pull request #4192: [BEAM-3041] preinstall various packages
for better startup performance and reliability
URL: https://github.com/apache/beam/pull/4192#discussion_r153684774
 
 

 ##########
 File path: sdks/python/container/Dockerfile
 ##########
 @@ -19,8 +19,64 @@
 FROM python:2
 MAINTAINER "Apache Beam <dev@beam.apache.org>"
 
-# TODO(herohde): preinstall various packages for better startup
-# performance and reliability.
+# Install native bindings required for dependencies.
+RUN apt-get update && \
+    apt-get install -y \
+       # These packages are needed for "pip install python-snappy" below.
+       libsnappy-dev \
+       # This package is needed for "pip install pyyaml" below to have c bindings.
+       libyaml-dev
 
 Review comment:
   You should remove the apt-get package lists as part of this command: rm -rf /var/lib/apt/lists/*

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add portable Python SDK container setup support
> -----------------------------------------------
>
>                 Key: BEAM-3041
>                 URL: https://issues.apache.org/jira/browse/BEAM-3041
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-harness
>            Reporter: Henning Rohde
>            Assignee: Ahmet Altay
>              Labels: portability
>
> The minimal python container setup should be brought up to par with SDK features:
>  - requirements.txt
>  - main session
>  - extra packages
> The name of the SDK package in boot.go should also not be hardcoded.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message