beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3142) Fix proto generation in Python 3
Date Sun, 05 Nov 2017 06:58:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239425#comment-16239425
] 

ASF GitHub Bot commented on BEAM-3142:
--------------------------------------

GitHub user holdenk opened a pull request:

    https://github.com/apache/beam/pull/4077

    [BEAM-3142] Apply futurize on gen_protos

    Python 3 removes relative import support, we can apply futurize on the generated protos
to fix the imports. It's less than ideal, but it works.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/holdenk/beam BEAM-3142-fix-proto-gen-for-py3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4077.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4077
    
----
commit 162da90ddc440e7cbd30ba3393d7e3d161fde8fc
Author: Holden Karau <holdenkarau@google.com>
Date:   2017-11-04T06:36:00Z

    Apply futurize on gen_protos

----


> Fix proto generation in Python 3
> --------------------------------
>
>                 Key: BEAM-3142
>                 URL: https://issues.apache.org/jira/browse/BEAM-3142
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: holdenk
>            Assignee: Ahmet Altay
>
> The generated Python code uses relative imports, fix this to be usable in Python 3.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message