beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3146) Fn Execution APIs should not depend on the Java SDK
Date Mon, 06 Nov 2017 23:35:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241185#comment-16241185
] 

ASF GitHub Bot commented on BEAM-3146:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/4084

    [BEAM-3146] Ban any Java SDK dependency in Fn Execution Libs

    A runner must not be forced to depend on any particular SDK during
    execution time. As these libraries are expected to be the default entry
    point into interacting with an SDK harness, these libraries may not
    introduce such a dependency edge, and are therefore prohibited.
    
    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam ban_sdk_dependencies_in_fn_execution

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4084.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4084
    
----
commit 9715f67f1c1b922a83044e8ac5d9dbb684c84513
Author: Thomas Groh <tgroh@google.com>
Date:   2017-11-06T23:16:26Z

    Ban any Java SDK dependency in Fn Execution Libs
    
    A runner must not be forced to depend on any particular SDK during
    execution time. As these libraries are expected to be the default entry
    point into interacting with an SDK harness, these libraries may not
    introduce such a dependency edge, and are therefore prohibited.

----


> Fn Execution APIs should not depend on the Java SDK
> ---------------------------------------------------
>
>                 Key: BEAM-3146
>                 URL: https://issues.apache.org/jira/browse/BEAM-3146
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> Runners should be able to interact with the Fn API with complete ignorance of the underlying
SDK, and as such should not obtain a dependency on the Java SDK.
> This dependency edge should be banned. This will also require moving shared model abstractions
which require code execution to a module on which both fn execution APIs and the Java SDK
can depend on.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message