beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (BEAM-2001) Verify PAssert execution in all runners
Date Fri, 26 Jan 2018 22:09:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kenneth Knowles resolved BEAM-2001.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Not applicable

All subtasks are resolved for the runners. And most likely since there are PAssertTest cases
that check it fails when it should there's not too much room for trouble anyhow.

> Verify PAssert execution in all runners
> ---------------------------------------
>
>                 Key: BEAM-2001
>                 URL: https://issues.apache.org/jira/browse/BEAM-2001
>             Project: Beam
>          Issue Type: Test
>          Components: runner-core
>            Reporter: Aviem Zur
>            Priority: Blocker
>             Fix For: Not applicable
>
>
> Currently, {{PAssert}} assertions may not happen and tests will pass while silently hiding
issues.
> For {{ValidatesRunner}} tests to truly validate a runner supports the model we need to
verify the {{PAssert}} assertions actually ran.
> See [dev list discussion|https://lists.apache.org/thread.html/9e6b9e6a21d2a657a1dd293b8cc8497c76a8a66fa3a1358733c02101@%3Cdev.beam.apache.org%3E].
> In order to reduce duplication, for runners which support metrics we could verify this
in {{TestPipeline}}, removing the need for the runner itself to make this assertion (See https://issues.apache.org/jira/browse/BEAM-1763).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message