beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-3287) Go SDK support for portable pipelines
Date Mon, 19 Mar 2018 18:27:01 GMT


ASF GitHub Bot logged work on BEAM-3287:

                Author: ASF GitHub Bot
            Created on: 19/Mar/18 18:26
            Start Date: 19/Mar/18 18:26
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on a change in pull request #4888: [BEAM-3287]
Add Go support for universal runners, incl Flink

 File path: sdks/go/pkg/beam/runners/universal/runnerlib/job.go
 @@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package runnerlib
+import (
+	"context"
+	"fmt"
+	"io"
+	""
+	""
+	""
+	jobpb ""
+	pb ""
+	""
+	""
+// JobOptions capture the various options for submitting jobs
+// to universal runners.
+type JobOptions struct {
+	// Name is the job name.
+	Name string
+	// Experiments are additional experiments.
+	Experiments []string
+	// TODO(herohde) 3/17/2018: add further parametrization as needed
+	// InternalJavaRunner is the class of the receiving Java runner. To be removed.
+	InternalJavaRunner string
+// Prepare prepares a job to the given endpoint. It returns an id and endpoint, if successful.
 Review comment:
   We may be able to improve this comment, as I'm having difficulty reconciling what's here,
and in the implementation.
    Knowing nothing about what PrepareJob request on the service does, but reading this implementation,
it looks like the idea is to prepare the runner to receive the job, largely by getting a place
to stage artifacts (like the worker) to run the job later.
   So, it's preparing the service for the job. Is that right?
   With that in mind, and looking at how the returns are used in this PR perhaps:
   // Prepare prepares a given Beam model runner to receive a job. If successful, Prepare
returns an id, and a URL
   // endpoint where the runner expects job artifacts to be staged.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 81952)
    Time Spent: 40m  (was: 0.5h)

> Go SDK support for portable pipelines
> -------------------------------------
>                 Key: BEAM-3287
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Henning Rohde
>            Priority: Major
>              Labels: portability
>          Time Spent: 40m
>  Remaining Estimate: 0h
> The Go SDK should participate in the portability framework, incl. job submission w/ a
docker container image.

This message was sent by Atlassian JIRA

View raw message