beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3977) Member classes of SdkHarnessClient should have their own files.
Date Sat, 31 Mar 2018 00:00:39 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3977?focusedWorklogId=86217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86217
]

ASF GitHub Bot logged work on BEAM-3977:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Mar/18 00:00
            Start Date: 31/Mar/18 00:00
    Worklog Time Spent: 10m 
      Work Description: axelmagn opened a new pull request #4988: [BEAM-3977] Move out nested
classes from SdkHarnessClient.
URL: https://github.com/apache/beam/pull/4988
 
 
   The SdkHarnessClient contained some nested subclasses complex
   enough to merit their own files.  This commit hopefully simplifies
   its reading by separating out related but distinct concepts into
   their own class files.
   
   This also contains a quick style cleanup in a separate commit.
   
   ------------------------
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [x] Write a pull request description that is detailed enough to understand:
      - [x] What the pull request does
      - [x] Why it does it
      - [x] How it does it
      - [x] Why this approach
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 86217)
            Time Spent: 10m
    Remaining Estimate: 0h

> Member classes of SdkHarnessClient should have their own files.
> ---------------------------------------------------------------
>
>                 Key: BEAM-3977
>                 URL: https://issues.apache.org/jira/browse/BEAM-3977
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core
>            Reporter: Axel Magnuson
>            Assignee: Axel Magnuson
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> SdkHarnessClient contains quite a few nested classes that could be split out.  of these,
BundleProcessor and ActiveBundle have grown up to be first class concepts that we interact
with just as much as the SdkHarnessClient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message