beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4000) Futurize and fix python 2 compatibility for io subpackage
Date Sat, 04 Aug 2018 00:53:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4000?focusedWorklogId=131153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131153
]

ASF GitHub Bot logged work on BEAM-4000:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Aug/18 00:52
            Start Date: 04/Aug/18 00:52
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #5715: [BEAM-4000]
Futurize io subpackage
URL: https://github.com/apache/beam/pull/5715#discussion_r207694773
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/pubsub.py
 ##########
 @@ -33,8 +33,9 @@
 from __future__ import absolute_import
 
 import re
+from builtins import object
 
-from six import text_type
+from past.builtins import basestring
 
 Review comment:
   It seems that on Python 2 this change translates to changing the `element_type` type from
`unicode` to `bytes`/`str` in line 176. 
   @chamikaramj Do you have an intuition if this could bite us?
   CC: @altay

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 131153)
    Time Spent: 6h 20m  (was: 6h 10m)

> Futurize and fix python 2 compatibility for io subpackage
> ---------------------------------------------------------
>
>                 Key: BEAM-4000
>                 URL: https://issues.apache.org/jira/browse/BEAM-4000
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Matthias Feys
>            Priority: Major
>             Fix For: Not applicable
>
>          Time Spent: 6h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message