beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4864) run_validatescontainer.sh in Python sdk has hard-coded bucket of sadness
Date Wed, 01 Aug 2018 11:59:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4864?focusedWorklogId=129665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-129665
]

ASF GitHub Bot logged work on BEAM-4864:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Aug/18 11:58
            Start Date: 01/Aug/18 11:58
    Worklog Time Spent: 10m 
      Work Description: alanmyrvold commented on a change in pull request #6061: [BEAM-4864]
Make run_validatescontainer.sh not quite as hard coded.
URL: https://github.com/apache/beam/pull/6061#discussion_r206851053
 
 

 ##########
 File path: sdks/python/container/run_validatescontainer.sh
 ##########
 @@ -25,14 +25,16 @@
 #
 # Execute from the root of the repository: sdks/python/container/run_validatescontainer.sh
 
+echo "This script must be executed in the root of beam project. Please set LOCAL_PATH, GCS_LCOATION,
and PROJECT as desired."
 
 Review comment:
   GCS_LOCATION

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 129665)
    Time Spent: 50m  (was: 40m)

> run_validatescontainer.sh in Python sdk has hard-coded bucket of sadness
> ------------------------------------------------------------------------
>
>                 Key: BEAM-4864
>                 URL: https://issues.apache.org/jira/browse/BEAM-4864
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-harness
>            Reporter: holdenk
>            Assignee: holdenk
>            Priority: Trivial
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The run_validatescontainer.sh script looks amazing! However I could not validate my container,
and this made me sad. We can make it configurable and then people can validate their container
changes more easily :)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message