beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-5072) SortRelNode is wrongly removed
Date Fri, 03 Aug 2018 23:01:00 GMT


ASF GitHub Bot logged work on BEAM-5072:

                Author: ASF GitHub Bot
            Created on: 03/Aug/18 23:00
            Start Date: 03/Aug/18 23:00
    Worklog Time Spent: 10m 
      Work Description: akedin commented on a change in pull request #6139: [BEAM-5072] Remove
RelCollationTraitDef configuration in BeamQueryPlanner

 File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/
 @@ -76,8 +75,7 @@
     final SchemaPlus schema = connection.getRootSchema();
     final SchemaPlus defaultSchema = JdbcDriver.getDefaultSchema(connection);
-    final ImmutableList<RelTraitDef> traitDefs =
-        ImmutableList.of(ConventionTraitDef.INSTANCE, RelCollationTraitDef.INSTANCE);
+    final ImmutableList<RelTraitDef> traitDefs = ImmutableList.of(ConventionTraitDef.INSTANCE);
 Review comment:
   This is only valid for `BeamSqlEnv` path. Does the JDBC path apply the CollationTrait?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 131121)
    Time Spent: 50m  (was: 40m)

> SortRelNode is wrongly removed
> ------------------------------
>                 Key: BEAM-5072
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
> ORDER BY query generates LogicalSort in logical plan, but it will be removed wrongly
during optimization by the SortRemoveRule

This message was sent by Atlassian JIRA

View raw message