beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3711) Implement portable Combiner lifting in Dataflow Runner
Date Wed, 19 Sep 2018 23:46:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3711?focusedWorklogId=145869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-145869
]

ASF GitHub Bot logged work on BEAM-3711:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Sep/18 23:45
            Start Date: 19/Sep/18 23:45
    Worklog Time Spent: 10m 
      Work Description: youngoli commented on a change in pull request #6384: [BEAM-3711]
Bug fix and improvements in Dataflow transform override.
URL: https://github.com/apache/beam/pull/6384#discussion_r218997990
 
 

 ##########
 File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPTransformMatchers.java
 ##########
 @@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.dataflow;
+
+import static com.google.common.base.MoreObjects.toStringHelper;
+
+import com.google.common.annotations.VisibleForTesting;
+import java.util.ArrayDeque;
+import org.apache.beam.sdk.Pipeline;
+import org.apache.beam.sdk.runners.AppliedPTransform;
+import org.apache.beam.sdk.runners.PTransformMatcher;
+import org.apache.beam.sdk.runners.TransformHierarchy;
+import org.apache.beam.sdk.transforms.Combine;
+import org.apache.beam.sdk.transforms.PTransform;
+
+/**
+ * A set of {@link PTransformMatcher PTransformMatchers} that are used in the Dataflow Runner
and
 
 Review comment:
   The first is the actual link and the second is the appearance. This should show as `PTransformMatchers`
but link to the singular `PTransformMatcher`. This is important because there's a class called
`PTransformMatchers` (plural) used as a namespace, and I'm trying *not* to link that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 145869)
    Time Spent: 2h 50m  (was: 2h 40m)

> Implement portable Combiner lifting in Dataflow Runner
> ------------------------------------------------------
>
>                 Key: BEAM-3711
>                 URL: https://issues.apache.org/jira/browse/BEAM-3711
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-dataflow
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: Major
>              Labels: portability
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> This is the task to make sure that once other parts of portable Combiner lifting are
complete, that the actual Combiner lifting can be done in the Dataflow Runner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message