beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4461) Create a library of useful transforms that use schemas
Date Wed, 05 Sep 2018 18:36:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=141490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-141490
]

ASF GitHub Bot logged work on BEAM-4461:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Sep/18 18:35
            Start Date: 05/Sep/18 18:35
    Worklog Time Spent: 10m 
      Work Description: akedin commented on a change in pull request #6318: [BEAM-4461] Some
fixes to Combiners needed for Schema support.
URL: https://github.com/apache/beam/pull/6318#discussion_r215361562
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java
 ##########
 @@ -470,7 +589,10 @@ public CoCombineResult extractOutput(Object[] accumulator, Context c)
{
         throws CannotProvideCoderException {
       List<Coder<Object>> coders = Lists.newArrayList();
       for (int i = 0; i < combineFnCount; ++i) {
-        Coder<Object> inputCoder = registry.getOutputCoder(extractInputFns.get(i),
dataCoder);
+        Coder<Object> inputCoder =
+            combineInputCoders.get(i).isPresent()
 
 Review comment:
   I think something like `combineInputCoders.get(i).or(registry.getOutputCoder(extractInputFns.get(i),
dataCoder))` should work.
   
   Also, I believe this logic should be changed, it would be clearer if the coders was not
a list of optionals, but a list of coders, and the registry was consulted before this instead
of adding `Optional.absent()`. The end goal is not to have optionals but use the values from
registry instead when no coder is passed. Similar to how `CombineFnUtil.toFnWithContext(globalCombineFn)`
is called.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 141490)

> Create a library of useful transforms that use schemas
> ------------------------------------------------------
>
>                 Key: BEAM-4461
>                 URL: https://issues.apache.org/jira/browse/BEAM-4461
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Reuven Lax
>            Assignee: Reuven Lax
>            Priority: Major
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> e.g. JoinBy(fields). Project, Filter, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message