beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4511) Create a tox environment that uses Py3 interpreter for pre/post commit test suites, once codebase supports Py3.
Date Wed, 05 Sep 2018 15:28:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4511?focusedWorklogId=141328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-141328
]

ASF GitHub Bot logged work on BEAM-4511:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Sep/18 15:27
            Start Date: 05/Sep/18 15:27
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on a change in pull request #6266: [BEAM-4511] added
py3 tox env for first test
URL: https://github.com/apache/beam/pull/6266#discussion_r215317938
 
 

 ##########
 File path: sdks/python/gen_protos.py
 ##########
 @@ -110,14 +112,17 @@ def generate_proto_files(force=False):
             'Protoc returned non-zero status (see logs for details): '
             '%s' % ret_code)
 
-    if sys.version_info[0] >= 3:
-      ret_code = subprocess.call(
-          ["futurize", "--both-stages", "--write", "--verbose", "--no-diff",
-           out_dir])
+    ret_code = subprocess.call(["pip", "install", "future==0.16.0"])
 
 Review comment:
   (unrelated to python3 and this pr).
   Could we convert gen_protos to tox task and control its environment that way including
installing grpcio and future?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 141328)
    Time Spent: 1h 40m  (was: 1.5h)

> Create a tox environment that uses Py3 interpreter for pre/post commit test suites, once
codebase supports Py3. 
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4511
>                 URL: https://issues.apache.org/jira/browse/BEAM-4511
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Assignee: Matthias Feys
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message