beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4704) String operations yield incorrect results when executed through SQL shell
Date Thu, 13 Sep 2018 17:58:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4704?focusedWorklogId=144036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144036
]

ASF GitHub Bot logged work on BEAM-4704:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/18 17:57
            Start Date: 13/Sep/18 17:57
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on issue #6389: [BEAM-4704] Disable enumerable
rules, use direct runner
URL: https://github.com/apache/beam/pull/6389#issuecomment-421096733
 
 
   R: @akedin 
   cc: @amaliujia 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 144036)
    Time Spent: 20m  (was: 10m)

> String operations yield incorrect results when executed through SQL shell
> -------------------------------------------------------------------------
>
>                 Key: BEAM-4704
>                 URL: https://issues.apache.org/jira/browse/BEAM-4704
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Kenneth Knowles
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{TRIM}} is defined to trim _all_ the characters in the first string from the string-to-be-trimmed.
Calcite has an incorrect implementation of this. We use our own fixed implementation. But
when executed through the SQL shell, the results do not match what we get from the PTransform
path. Here two test cases that pass on {{master}} but are incorrect in the shell:
> {code:sql}
> BeamSQL> select TRIM(LEADING 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__hehe |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(TRAILING 'eh' FROM 'hehe__hehe');
> +------------+
> |   EXPR$0   |
> +------------+
> | hehe__heh  |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(BOTH 'eh' FROM 'hehe__hehe');
> +------------+
> |   EXPR$0   |
> +------------+
> | hehe__heh  |
> +------------+
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message