beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4790) Make it easier to select code reviewers for PRs
Date Wed, 05 Sep 2018 20:56:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4790?focusedWorklogId=141530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-141530
]

ASF GitHub Bot logged work on BEAM-4790:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Sep/18 20:55
            Start Date: 05/Sep/18 20:55
    Worklog Time Spent: 10m 
      Work Description: asfgit closed pull request #545: [BEAM-4790] Contribute: document
how to find and add reviewers
URL: https://github.com/apache/beam-site/pull/545
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/contribute/index.md b/src/contribute/index.md
index b202214218..a26ca8939a 100644
--- a/src/contribute/index.md
+++ b/src/contribute/index.md
@@ -228,6 +228,36 @@ $ python setup.py sdist > /dev/null && \
         --sdk_location dist/apache-beam-2.5.0.dev0.tar.gz
 ```
 
+## Reviews
+
+Reviewers for [apache/beam](https://github.com/apache/beam) are listed in
+Prow-style OWNERS files. A description of these files can be found
+[here](https://go.k8s.io/owners).
+
+### Finding reviewers
+
+Currently this is a manual process. Tracking bug for automating this:
+[BEAM-4790](https://issues.apache.org/jira/browse/BEAM-4790).
+
+For each file to be reviewed, look for an OWNERS file in its directory. Pick a
+single reviewer from that file. If the directory doesn't contain an OWNERS file,
+go up a directory. Keep going until you find one. Try to limit the number of
+reviewers to 2 per PR if possible, to minimize reviewer load.
+
+### Adding yourself as a reviewer
+
+Find the deepest sub-directory that contains the files you want to be a reviewer
+for and add your Github username under `reviewers` in the OWNERS file (create a
+new OWNERS file if necessary).
+
+The Beam project currently only uses the `reviewers` key in OWNERS and no other
+features, as reviewer selection is still a manual process.
+
+<!-- TODO(BEAM-4790): If Prow write access gets approved
+(https://issues.apache.org/jira/browse/INFRA-16869), document that if you are
+not a committer you can still be listed as a reviewer. Just ask to get added as
+a read-only collaborator to apache/beam by opening an INFRA ticket. -->
+
 ## Contributing to the website
 
 The Beam website is in the [Beam Site GitHub


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 141530)
    Time Spent: 3h 40m  (was: 3.5h)

> Make it easier to select code reviewers for PRs
> -----------------------------------------------
>
>                 Key: BEAM-4790
>                 URL: https://issues.apache.org/jira/browse/BEAM-4790
>             Project: Beam
>          Issue Type: Improvement
>          Components: project-management
>            Reporter: Udi Meiri
>            Assignee: Udi Meiri
>            Priority: Major
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> The original idea was to use Github's CODEOWNERS feature, but that turned out to not
work well for Apache Beam.
> Thread: https://lists.apache.org/thread.html/9cc3191b21489c855ed502beade6d453b18e26eec46cb2c3dfe810e9@%3Cdev.beam.apache.org%3E
> Document discussing this idea:
> https://docs.google.com/document/d/184Tn0ONJ2ENHBVrhIes4seVuBSkww7xX5xb5W2VZwm8/edit#heading=h.l7mcrg761zp8
> Mailing list thread:
> https://lists.apache.org/thread.html/6138d08c551e254b5f13b26c6ba06579a49a4694f4d13ad6d164689a@%3Cdev.beam.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message